-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ webserver-catalog rpc connection #6003
✨ webserver-catalog rpc connection #6003
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6003 +/- ##
=========================================
+ Coverage 84.5% 87.8% +3.2%
=========================================
Files 10 1425 +1415
Lines 214 58451 +58237
Branches 25 1396 +1371
=========================================
+ Hits 181 51359 +51178
- Misses 23 6798 +6775
- Partials 10 294 +284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, please adjust the code to our current convention for defining the RPC endpoints
packages/models-library/src/models_library/api_schemas_webserver/catalog.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/catalog/_rpc.py
Outdated
Show resolved
Hide resolved
0a20de9
to
ef59c19
Compare
services/catalog/src/simcore_service_catalog/api/rest/_services.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/services/access_rights.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/services/access_rights.py
Outdated
Show resolved
Hide resolved
services/catalog/src/simcore_service_catalog/services/access_rights.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please change the call back to is_old_service, maybe by adding a comment for it. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot. I have a few questions (mostly for my understanding) below.
services/catalog/src/simcore_service_catalog/api/rpc/_services.py
Outdated
Show resolved
Hide resolved
722846c
to
ea2c394
Compare
85c8415
to
91f835e
Compare
81a910a
to
2f1b581
Compare
What do these changes do?
This PR exposes an

rpc
interface in thecatalog
and uses it in thewebserver
.catalog
rabbitmq
rcp
serverwebserver
'scatalog
plugin_rpc
client_api
module (service layer):- get catalog
_rpc
results and aggregates i/o_handlers
(controller layer)- implemented using
_api
Related issue/s
How to test
_rpc
client callsDev-ops checklist
catalog
service now interacts with rabbitmq. AddedRABBITMQ_
related env-vars. No changes required inosparc-ops
!