Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] dev/services fixes #6094

Merged
merged 5 commits into from
Jul 23, 2024
Merged

🐛 [Frontend] dev/services fixes #6094

merged 5 commits into from
Jul 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 23, 2024 •
edited
Loading

What do these changes do?

Fixes:

  • Version selector with version display
  • Use new PATCH endpoint
  • Do not allow editing version display if user can't write

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz marked this pull request as ready for review July 23, 2024 15:12
@odeimaiz odeimaiz requested review from jsaq007 and ignapas as code owners July 23, 2024 15:12
@odeimaiz odeimaiz enabled auto-merge (squash) July 23, 2024 15:13
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Fix version selector with version display 🐛 [Frontend] dev/services fixes Jul 23, 2024
sanderegg
sanderegg approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz self-assigned this Jul 23, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jul 23, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Jul 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit 38c7d39 into ITISFoundation:master Jul 23, 2024
50 of 51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 15, 2024
Closed
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignapas ignapas ignapas approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@pcrespov pcrespov Awaiting requested review from pcrespov

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @ignapas @sanderegg @matusdrobuliak66