🐛 Fix missing redis-commaner password support #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… machines (⚠️ Devops) 🚨 (ITISFoundation#5923)
…tion#6052) Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrei Neagu <[email protected]>
Merged on behalf of @bisgaard-itis . Needed for staging release
mrnicegyu11
requested review from
pcrespov,
sanderegg,
GitHK,
matusdrobuliak66 and
YuryHrytsuk
as code owners
YuryHrytsuk
approved these changes
Aug 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
=========================================
+ Coverage 84.5% 87.9% +3.4%
=========================================
Files 10 1401 +1391
Lines 214 58790 +58576
Branches 25 1480 +1455
=========================================
+ Hits 181 51733 +51552
- Misses 23 6746 +6723
- Partials 10 311 +301
Flags with carried forward coverage won't be shown. Click here to find out more. |
matusdrobuliak66
approved these changes
Aug 2, 2024
GitHK
approved these changes
Aug 2, 2024
services/web/server/tests/unit/with_dbs/docker-compose-devel.yml
Outdated
Show resolved
Hide resolved
sanderegg
reviewed
Aug 5, 2024
Co-authored-by: Andrei Neagu <[email protected]>
The |
pcrespov
reviewed
Aug 9, 2024
pcrespov
approved these changes
Aug 9, 2024
|
This was referenced Aug 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When the password authentication for redis was added, I forgot to add the password to the redis-commander. This PR adds it.
Related issue/s
How to test
Dev-ops checklist