Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Prettify "Creating template" progress #6267

Merged
merged 21 commits into from
Sep 5, 2024
Merged

🎨 [Frontend] Prettify "Creating template" progress #6267

merged 21 commits into from
Sep 5, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 29, 2024 •
edited
Loading

What do these changes do?

  • Refactor the Node Progress class to be used with Long running tasks
  • Show product logo on Loading screens

Before:
CreateProjectBefore

After:
CreateProject

Related issue/s

closes ITISFoundation/osparc-issues#1628

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 29, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 30, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 30, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 4, 2024 14:47
@odeimaiz odeimaiz enabled auto-merge (squash) September 4, 2024 16:10
GitHK
GitHK approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 much better UX!

sanderegg
sanderegg reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

jsaq007
jsaq007 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. ;) Maybe the fields hidden to start is a little misleading and not consistent with the original / starting project?

@odeimaiz
Copy link
Member Author

odeimaiz commented Sep 5, 2024

Looks nice. ;) Maybe the fields hidden to start is a little misleading and not consistent with the original / starting project?

That's because the sequence is not fixed.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit b1978ad into ITISFoundation:master Sep 5, 2024
51 checks passed
This was referenced Sep 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@jsaq007 jsaq007 jsaq007 approved these changes

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Eisbock
Development

Successfully merging this pull request may close these issues.

"copying project" / "instantiating template" status bar UX improvements
6 participants
@odeimaiz @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66