-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Improve worskpace feature (1. Part) #6303
🎨 Improve worskpace feature (1. Part) #6303
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6303 +/- ##
=========================================
+ Coverage 84.5% 88.8% +4.3%
=========================================
Files 10 1214 +1204
Lines 214 53399 +53185
Branches 25 865 +840
=========================================
+ Hits 181 47466 +47285
- Misses 23 5802 +5779
- Partials 10 131 +121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…k66/osparc-simcore into improve-worskpaces-feature
…k66/osparc-simcore into improve-worskpaces-feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR fixes the issue with the closing of jupyter lab, can you please reference it so that it actually gets closed? thanks. Actually I saw this does not fix it but only disable locally.
Otherwise thanks for the rest
services/web/server/src/simcore_service_webserver/projects/_crud_api_create.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_crud_api_create.py
Show resolved
Hide resolved
.../server/tests/unit/with_dbs/02/test_projects_crud_handlers__clone_in_workspace_and_folder.py
Show resolved
Hide resolved
.../server/tests/unit/with_dbs/02/test_projects_crud_handlers__clone_in_workspace_and_folder.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go go go!!
…k66/osparc-simcore into improve-worskpaces-feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
services/web/server/src/simcore_service_webserver/workspaces/_workspaces_db.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_tags_api.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
@odeimaiz first part of improvements
workspace_id
andfolder_id
on creation of projectworkspace_id
tofolderGet
myAccessRIghts
tofolderGet
Bonus: set
AWS_S3_CLI_S3
to nullIn the next PR moving between workspaces will be introduced
Related issue/s
How to test
Dev-ops checklist