Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improve worskpace feature (1. Part) #6303

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Sep 4, 2024

What do these changes do?

@odeimaiz first part of improvements

  • Add workspace_id and folder_id on creation of project
  • overwrite project access rights with workspace access rights if project in workspace
  • add workspace_id to folderGet
  • add myAccessRIghts to folderGet

Bonus: set AWS_S3_CLI_S3 to null

In the next PR moving between workspaces will be introduced

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.8%. Comparing base (cafbf96) to head (022cfff).
Report is 508 commits behind head on master.

Files with missing lines Patch % Lines
.../simcore_service_webserver/folders/_folders_api.py 69.2% 4 Missing ⚠️
...rc/simcore_service_webserver/projects/_tags_api.py 50.0% 4 Missing ⚠️
...ore_service_webserver/projects/_crud_api_create.py 90.4% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6303      +/-   ##
=========================================
+ Coverage    84.5%   88.8%    +4.3%     
=========================================
  Files          10    1214    +1204     
  Lines         214   53399   +53185     
  Branches       25     865     +840     
=========================================
+ Hits          181   47466   +47285     
- Misses         23    5802    +5779     
- Partials       10     131     +121     
Flag Coverage Δ
integrationtests 64.6% <28.8%> (?)
unittests 86.5% <84.6%> (+1.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...models_library/api_schemas_webserver/folders_v2.py 100.0% <100.0%> (ø)
...c/models_library/api_schemas_webserver/projects.py 100.0% <100.0%> (ø)
...e_service_webserver/projects/_access_rights_api.py 97.1% <ø> (ø)
...mcore_service_webserver/projects/_crud_api_read.py 97.7% <100.0%> (ø)
...mcore_service_webserver/projects/_crud_handlers.py 91.9% <ø> (ø)
...simcore_service_webserver/projects/_folders_api.py 93.5% <ø> (ø)
...simcore_service_webserver/projects/projects_api.py 84.5% <100.0%> (ø)
...ore_service_webserver/workspaces/_workspaces_db.py 96.7% <ø> (ø)
...er/src/simcore_service_webserver/workspaces/api.py 100.0% <100.0%> (ø)
...ore_service_webserver/projects/_crud_api_create.py 97.2% <90.4%> (ø)
... and 2 more

... and 1190 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 5, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Eisbock milestone Sep 5, 2024
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR fixes the issue with the closing of jupyter lab, can you please reference it so that it actually gets closed? thanks. Actually I saw this does not fix it but only disable locally.

Otherwise thanks for the rest

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go!!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 5, 2024 09:50
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link

sonarqubecloud bot commented Sep 5, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit 1c16908 into ITISFoundation:master Sep 5, 2024
57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-worskpaces-feature branch September 5, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants