Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 moving projects between workspaces #6312

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • 🎨 moving projects between workspaces

Related issue/s

How to test

test_workspaces__moving_projects_between_workspaces.py

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 5, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Eisbock milestone Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.4%. Comparing base (cafbf96) to head (a44f45d).
Report is 509 commits behind head on master.

Files with missing lines Patch % Lines
...service_webserver/projects/_workspaces_handlers.py 95.5% 2 Missing ⚠️
...ore_service_webserver/projects/_crud_api_create.py 0.0% 1 Missing ⚠️
...core_service_webserver/projects/_workspaces_api.py 96.1% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6312      +/-   ##
=========================================
- Coverage    84.5%   82.4%    -2.2%     
=========================================
  Files          10     589     +579     
  Lines         214   30086   +29872     
  Branches       25     260     +235     
=========================================
+ Hits          181   24795   +24614     
- Misses         23    5231    +5208     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.6% <67.0%> (?)
unittests 88.0% <94.9%> (+3.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../simcore_service_webserver/projects/_folders_db.py 100.0% <100.0%> (ø)
...c/simcore_service_webserver/projects/_groups_db.py 96.4% <100.0%> (ø)
...r/src/simcore_service_webserver/projects/plugin.py 100.0% <100.0%> (ø)
..._service_webserver/security/_authz_access_roles.py 100.0% <ø> (ø)
...ore_service_webserver/projects/_crud_api_create.py 96.6% <0.0%> (ø)
...core_service_webserver/projects/_workspaces_api.py 96.1% <96.1%> (ø)
...service_webserver/projects/_workspaces_handlers.py 95.5% <95.5%> (ø)

... and 592 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 5, 2024 14:30
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 5, 2024 17:15
Copy link

sonarqubecloud bot commented Sep 5, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit 37ce5ae into ITISFoundation:master Sep 5, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants