Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒️ Make Redis Client support TLS #6342

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Sep 10, 2024

What do these changes do?

Make Redis Client support TLS via REDIS_SECURE field

Related issue/s

How to test

Dev-ops checklist

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great mesmerizing 👍 thanks

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.2%. Comparing base (cafbf96) to head (547d50f).
Report is 527 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6342      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10    1499    +1489     
  Lines         214   62101   +61887     
  Branches       25    2065    +2040     
=========================================
+ Hits          181   54793   +54612     
- Misses         23    6992    +6969     
- Partials       10     316     +306     
Flag Coverage Δ
integrationtests 64.5% <ø> (?)
unittests 86.2% <100.0%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/settings-library/src/settings_library/redis.py 95.6% <100.0%> (ø)

... and 1447 files with indirect coverage changes

@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) September 10, 2024 14:55
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thxssss ;-)

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) September 11, 2024 07:29
Copy link

@sanderegg sanderegg disabled auto-merge September 11, 2024 11:56
@sanderegg sanderegg merged commit 913ff92 into ITISFoundation:master Sep 11, 2024
57 checks passed
@YuryHrytsuk YuryHrytsuk deleted the redis-client-tls-support branch September 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants