Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Force reload no-cache #6397

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 19, 2024

What do these changes do?

I finally found a user-friendly way to hard reload the app 🥳.

When the osparc detects the that there is a new version available, we will show the A new version of the application is now available. message together with Click the Reload button to get the latest features. and the Reload button.

This button will reload the page adding a qooxdoo-specific argument: "?qooxdoo:add-no-cache=true".

This argument, which is passed and consumed by the boot.js init file, adds a nocache=rand() query argument to the js resource calls. This forces a hard reload!

NoCache

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 19, 2024
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Sep 19, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.6%. Comparing base (cafbf96) to head (a44e2c6).
Report is 559 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cafbf96) and HEAD (a44e2c6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cafbf96) HEAD (a44e2c6)
unittests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6397      +/-   ##
=========================================
- Coverage    84.5%   64.6%   -19.9%     
=========================================
  Files          10     595     +585     
  Lines         214   30393   +30179     
  Branches       25     260     +235     
=========================================
+ Hits          181   19664   +19483     
- Misses         23   10669   +10646     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 605 files with indirect coverage changes

@odeimaiz odeimaiz changed the title ✨ [Frontend] Force no_cache ✨ [Frontend] Force no-cache Sep 19, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 19, 2024 12:17
@odeimaiz odeimaiz changed the title ✨ [Frontend] Force no-cache ✨ [Frontend] Force reload no-cache Sep 19, 2024
Copy link

@YuryHrytsuk
Copy link
Contributor

🔥

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@odeimaiz odeimaiz merged commit b8592ca into ITISFoundation:master Sep 19, 2024
51 checks passed
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants