-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Improved Error Handling for Missing Billing Details #6418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6418 +/- ##
=========================================
+ Coverage 84.5% 90.2% +5.6%
=========================================
Files 10 1178 +1168
Lines 214 51803 +51589
Branches 25 865 +840
=========================================
+ Hits 181 46734 +46553
- Misses 23 4938 +4915
- Partials 10 131 +121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dc0d090
to
7daf755
Compare
|
What do these changes do?
Improved Error Handling for Missing Pre-registration and Billing Details**
Previously, when account setup was incomplete or pre-registration information (such as billing country) was missing, the payment process would fail raising an 500 that displayed confusing message in the front-end (should be address in #5487). This was due to the REST handlers not properly addressing the absence of required billing details.
With this update, the service now responds with
HTTP_503_SERVICE_UNAVAILABLE
and an explicit message indicating that the payment service is unavailable until the necessary billing details are provided. Currently, these details can only be supplied on the service side (filling theuser_pre_registration
table).Additionally, errors related to missing billing information are now logged with an
OEC
code and relevant debug data, making them easier to trace in the logs or use as triggers for alerts.Related issue/s
How to test
Dev-ops checklist