Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] App mode: Scrollable Instructions #6430

Merged
merged 12 commits into from
Sep 24, 2024
Merged

🎨 [Frontend] App mode: Scrollable Instructions #6430

merged 12 commits into from
Sep 24, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 24, 2024 •
edited
Loading

What do these changes do?

  • Add scroll bars to Instructions window
  • Make it wider
  • Make the height more flexible

Bonus:

  • TIP videos in Quick Start
  • Default to empty country if auto select doesn't work
  • rewording: end users -> end-users

Before:
MarkdownBefore

After:
Markdown

Related issue/s

related to ITISFoundation/osparc-issues#1701

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 24, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 24, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Sep 24, 2024
@odeimaiz odeimaiz marked this pull request as ready for review September 24, 2024 14:59
matusdrobuliak66
matusdrobuliak66 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Nice

@odeimaiz odeimaiz enabled auto-merge (squash) September 24, 2024 15:19
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz requested a review from calys September 24, 2024 16:04
@odeimaiz odeimaiz merged commit 14e38d4 into ITISFoundation:master Sep 24, 2024
50 checks passed
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Sep 25, 2024
@odeimaiz @jsaq007
🎨 [Frontend] App mode: Scrollable Instructions (ITISFoundation#6430)
8129783
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] App mode: Scrollable Instructions (ITISFoundation#6430)
83c79c6
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignapas ignapas ignapas approved these changes

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007

@GitHK GitHK Awaiting requested review from GitHK

@Konohana0608 Konohana0608 Awaiting requested review from Konohana0608

@calys calys Awaiting requested review from calys

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @ignapas @pcrespov @matusdrobuliak66