-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ποΈ Strip credentials form image VCS #6433
ποΈ Strip credentials form image VCS #6433
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #6433 +/- ##
=========================================
+ Coverage 84.5% 88.3% +3.7%
=========================================
Files 10 1089 +1079
Lines 214 48815 +48601
Branches 25 406 +381
=========================================
+ Hits 181 43134 +42953
- Misses 23 5602 +5579
- Partials 10 79 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
packages/service-integration/src/service_integration/cli/_compose_spec.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
|
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
Strip credentials from docker image labels. While not immediately an issue, it will leak credentials if docker images of the services come in the possession of third parties. During normal operation this does not happen.
Related issue/s
How to test
Dev-ops checklist