Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes issue with parsing logs polluting sidecar logs #6442

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Sep 25, 2024

What do these changes do?

This issue was polluting the logs with tracebacks, event though it had no side effect.
Issue was caused by a missing parser for a log line similar to '{"level":"info","msg":"There was nothing to transfer","source":"sync/sync.go:954","time":"2024-09-25T10:18:04.904537+00:00"}'

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Sep 25, 2024
@GitHK GitHK added this to the MartinKippenberger milestone Sep 25, 2024
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Sep 25, 2024
@GitHK GitHK marked this pull request as ready for review September 25, 2024 11:26
@GitHK GitHK changed the title 🐛 Fees issue with parsing logs creating logs of errors in sidecars 🐛 Fixes issue with parsing logs polluting sidecar logs Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.8%. Comparing base (cafbf96) to head (5145784).
Report is 590 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6442      +/-   ##
=========================================
+ Coverage    84.5%   88.8%    +4.2%     
=========================================
  Files          10    1067    +1057     
  Lines         214   47582   +47368     
  Branches       25     265     +240     
=========================================
+ Hits          181   42256   +42075     
- Misses         23    5267    +5244     
- Partials       10      59      +49     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...src/simcore_sdk/node_ports_common/r_clone_utils.py 100.0% <ø> (ø)

... and 1076 files with indirect coverage changes

@GitHK GitHK added the bug buggy, it does not work as expected label Sep 25, 2024
@GitHK GitHK enabled auto-merge (squash) September 25, 2024 12:56
Copy link

@GitHK GitHK merged commit f57b3a9 into ITISFoundation:master Sep 26, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-log-parsing-issues branch September 26, 2024 07:03
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check log parsing
4 participants