-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes issue with parsing logs polluting sidecar logs #6442
Merged
GitHK
merged 5 commits into
ITISFoundation:master
from
GitHK:pr-osparc-log-parsing-issues
Sep 26, 2024
Merged
🐛 Fixes issue with parsing logs polluting sidecar logs #6442
GitHK
merged 5 commits into
ITISFoundation:master
from
GitHK:pr-osparc-log-parsing-issues
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6442 +/- ##
=========================================
+ Coverage 84.5% 88.8% +4.2%
=========================================
Files 10 1067 +1057
Lines 214 47582 +47368
Branches 25 265 +240
=========================================
+ Hits 181 42256 +42075
- Misses 23 5267 +5244
- Partials 10 59 +49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
approved these changes
Sep 25, 2024
giancarloromeo
approved these changes
Sep 25, 2024
pcrespov
approved these changes
Sep 25, 2024
|
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Oct 2, 2024
…n#6442) Co-authored-by: Andrei Neagu <[email protected]>
16 tasks
This was referenced Oct 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This issue was polluting the logs with tracebacks, event though it had no side effect.
Issue was caused by a missing parser for a log line similar to
'{"level":"info","msg":"There was nothing to transfer","source":"sync/sync.go:954","time":"2024-09-25T10:18:04.904537+00:00"}'
Related issue/s
How to test
Dev-ops checklist