Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ e2e: Fixes typo in tests #6468

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 30, 2024

What do these changes do?

Fixes a typo in logger formatter in #6459
This should fix e2e master failures

CC: batman @mrnicegyu11

Related issue/s

How to test

Dev-ops checklist

NOne

Copy link

@pcrespov pcrespov self-assigned this Sep 30, 2024
@pcrespov pcrespov added the e2e Bugs found by or related to the end-2-end testing label Sep 30, 2024
@pcrespov pcrespov changed the title ✅ Fixes typo in e2e tests ✅ e2e: Fixes typo in tests Sep 30, 2024
@pcrespov pcrespov enabled auto-merge (squash) September 30, 2024 08:53
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.2%. Comparing base (cafbf96) to head (37a9f0b).
Report is 597 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6468      +/-   ##
=========================================
+ Coverage    84.5%   86.2%    +1.6%     
=========================================
  Files          10    1526    +1516     
  Lines         214   62809   +62595     
  Branches       25    2029    +2004     
=========================================
+ Hits          181   54159   +53978     
- Misses         23    8351    +8328     
- Partials       10     299     +289     
Flag Coverage Δ
unittests 86.2% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1476 files with indirect coverage changes

@pcrespov pcrespov disabled auto-merge September 30, 2024 09:00
@pcrespov pcrespov merged commit dbc5870 into ITISFoundation:master Sep 30, 2024
41 of 42 checks passed
@pcrespov pcrespov deleted the fix/e2e-master branch September 30, 2024 09:00
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants