Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove Efs Guardian for devel model #6540

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 15, 2024

What do these changes do?

  • 🐛 Remove Efs Guardian for devel model - efs is running as a root which causes troubles when running devel mode locally.

Related issue/s

How to test

Dev-ops checklist

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
For later, if you do not use devel mode you could also remove it.
we could also use UV since this guy installs in a few ms

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (a831df1).
Report is 637 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6540      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1548    +1538     
  Lines         214   63350   +63136     
  Branches       25    2059    +2034     
=========================================
+ Hits          181   55830   +55649     
- Misses         23    7201    +7178     
- Partials       10     319     +309     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1498 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 15, 2024 16:09
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 15, 2024 16:11
@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 16, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Oct 16, 2024
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 17fe63a into ITISFoundation:master Oct 16, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EFS-Guardian devel mode breaks devel mode
3 participants