-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Renaming session cookie once again #6544
♻️ Renaming session cookie once again #6544
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6544 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1548 +1538
Lines 214 63350 +63136
Branches 25 2059 +2034
=========================================
+ Hits 181 55836 +55655
- Misses 23 7195 +7172
- Partials 10 319 +309
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This will break a few e2e ops tests because we explicitly rely on Cookie name. We need to update these tests as soon as this fix is rolled out. Furthermore, this needs to be done in stages (master --> stag --> prod) I will take care of it |
I wonder if there are other places that explicitly rely on this cookie name. I hope there are no such 3rd parties |
inside the simcore codebase there are no other places. And we have tests to avoid cookie being out of sync that fail. |
What do these changes do?
Apparently
Firefox
handles cookies differently thanChrome
andSafari
. It keeps cookies with the same name but different domains.Even after invalidating the session key for the cookies. You login into
Firefox
open a new style dynamic service and authentication fails. Apparently it send out old cookie, the one with domainosparc.io
(which is invalid) instead of the one with.osparc.io
domain. This causes a 401 reply when openingUUID.services.osparc.io
.To avoid issues for users, the session cookie is being renamed.
Related issue/s
How to test
Dev-ops checklist