Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] TIP.itis.swiss: Show Phase out message at Request Account #6552

Merged
merged 3 commits into from
Oct 17, 2024
Merged

🎨 [Frontend] TIP.itis.swiss: Show Phase out message at Request Account #6552

merged 3 commits into from
Oct 17, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 17, 2024 •
edited
Loading

What do these changes do?

As requested by @calys, this PR makes the Request Account button in https://tip.itis.swiss/ behave differently. Hardcoded in the frontend code, it will pop a dialog saying:

This version of the planning tool will be phased out soon and no longer accepts new users.
Please visit TIP.lite or TIP instead. See here for more information.

PhaseOut

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 17, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 17, 2024 08:37
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 17, 2024
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Oct 17, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) October 17, 2024 08:40
@calys
Copy link

calys commented Oct 17, 2024

awesome, thanks Odei.

pcrespov
pcrespov reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer more flexible, dynamic solutions over hard-coded approaches, but I understand that, given this is a one-time scenario, a hard-coded method provides the largest return of investment. :-)

sanderegg
sanderegg reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jsaq007
jsaq007 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@odeimaiz odeimaiz merged commit 990292e into ITISFoundation:master Oct 17, 2024
50 of 51 checks passed
This was referenced Oct 22, 2024
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg left review comments

@jsaq007 jsaq007 jsaq007 approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@calys calys Awaiting requested review from calys

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @calys @jsaq007 @GitHK @pcrespov @sanderegg