Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Frontend] Guest viewers #6565

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

odeimaiz
Copy link
Member

What do these changes do?

Spotted in the e2e-portal VTK_dispatcher, the NodeViewer for guest users sometimes fails during the node start up process, because the frontend wasn't listening to the socket. This PR fixes it.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 18, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 18, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 18, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) October 18, 2024 15:04
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

Copy link

@odeimaiz odeimaiz merged commit 3c24a0e into ITISFoundation:master Oct 21, 2024
50 of 51 checks passed
@odeimaiz odeimaiz deleted the fix/guest-viewers branch October 21, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants