Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Maintenance: Improve UV usage #6566

Merged
merged 23 commits into from
Oct 22, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 18, 2024

What do these changes do?

This PR brings:

  • follow UV documentation to install in docker: https://docs.astral.sh/uv/guides/integration/docker/#installing-uv
  • added docker build argument to set UV version
  • added UV all over the place where python is used
  • removed pip installation in all these Dockerfile
  • updated UV to 0.4 version
  • all boot.sh scripts were adapted to use UV instead of PIP --> devel mode startup speed increase
  • moved installation of debugpy from entrypoint.sh to boot.sh @bisgaard-itis do yo know why you did it like so? I could not find out
  • reverted _tools.txt of director-v0 that was wrong and making director-v0 fail in devel mode

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Oct 18, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 18, 2024
@sanderegg sanderegg self-assigned this Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.8%. Comparing base (cafbf96) to head (7af3cc9).
Report is 663 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6566      +/-   ##
=========================================
+ Coverage    84.5%   88.8%    +4.2%     
=========================================
  Files          10    1366    +1356     
  Lines         214   57181   +56967     
  Branches       25    1118    +1093     
=========================================
+ Hits          181   50814   +50633     
- Misses         23    6193    +6170     
- Partials       10     174     +164     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.6% <ø> (+2.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1330 files with indirect coverage changes

@sanderegg sanderegg force-pushed the maintenance/uv-fixes branch 2 times, most recently from 87c80c3 to f3158bd Compare October 22, 2024 06:25
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Oct 22, 2024
@sanderegg sanderegg marked this pull request as ready for review October 22, 2024 07:48
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sanderegg sanderegg requested a review from mguidon October 22, 2024 09:25
@sanderegg sanderegg force-pushed the maintenance/uv-fixes branch 2 times, most recently from 9485977 to ac505c8 Compare October 22, 2024 13:33
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks a lot! I just have one small worry, which is that uv is still quite a new tool (right?) so there still might be a lot of changes to the interface etc. And now we depend on it everywhere...

@sanderegg
Copy link
Member Author

Very cool, thanks a lot! I just have one small worry, which is that uv is still quite a new tool (right?) so there still might be a lot of changes to the interface etc. And now we depend on it everywhere...

@bisgaard-itis no worries, we are using UV like for a few months already. Also many other open source projects have switched already. the speed increase vs pip is so enormous that everyone is moving.

@sanderegg sanderegg force-pushed the maintenance/uv-fixes branch from ac505c8 to cf911fd Compare October 22, 2024 15:16
@sanderegg sanderegg force-pushed the maintenance/uv-fixes branch from cf911fd to 7af3cc9 Compare October 22, 2024 19:43
Copy link

@sanderegg sanderegg merged commit ea88f43 into ITISFoundation:master Oct 22, 2024
56 checks passed
@sanderegg sanderegg deleted the maintenance/uv-fixes branch October 22, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants