Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 EFS Guardian - not need of owner information if project lock in MAINTAINING state 🚨 #6581

Merged
merged 12 commits into from
Oct 24, 2024

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 23, 2024

What do these changes do?

EFS Guardian:

  • 🐛 not need of owner information if project lock in MAINTAINING state

image
With the new MAINTAINING state, putting "owner" there doesn't make sense.

  • 🐛 fix ms -> to s (seconds) in background task scheduling

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.9%. Comparing base (cafbf96) to head (aab352e).
Report is 669 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6581      +/-   ##
=========================================
+ Coverage    84.5%   88.9%    +4.3%     
=========================================
  Files          10    1266    +1256     
  Lines         214   55224   +55010     
  Branches       25     885     +860     
=========================================
+ Hits          181   49098   +48917     
- Misses         23    5992    +5969     
- Partials       10     134     +124     
Flag Coverage Δ
integrationtests 64.7% <ø> (?)
unittests 86.5% <100.0%> (+2.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...odels-library/src/models_library/projects_state.py 93.8% <100.0%> (ø)
..._service_efs_guardian/services/background_tasks.py 93.5% <100.0%> (ø)
...ce_efs_guardian/services/background_tasks_setup.py 75.6% <100.0%> (ø)
...ce_efs_guardian/services/process_messages_setup.py 94.8% <ø> (ø)

... and 1246 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 23, 2024 08:17
@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 23, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 EFS Guardian - not need of owner information if project lock in MAINTAINING state 🐛 EFS Guardian - not need of owner information if project lock in MAINTAINING state 🚨 Oct 23, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Oct 23, 2024
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 23, 2024 12:26
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments, thanks

Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 326a11c into ITISFoundation:master Oct 24, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants