-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 EFS Guardian - not need of owner information if project lock in MAINTAINING state 🚨 #6581
🐛 EFS Guardian - not need of owner information if project lock in MAINTAINING state 🚨 #6581
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6581 +/- ##
=========================================
+ Coverage 84.5% 88.9% +4.3%
=========================================
Files 10 1266 +1256
Lines 214 55224 +55010
Branches 25 885 +860
=========================================
+ Hits 181 49098 +48917
- Misses 23 5992 +5969
- Partials 10 134 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments, thanks
services/efs-guardian/src/simcore_service_efs_guardian/services/background_tasks_setup.py
Show resolved
Hide resolved
|
What do these changes do?
EFS Guardian:
MAINTAINING
stateWith the new
MAINTAINING
state, putting "owner" there doesn't make sense.ms
-> tos
(seconds) in background task schedulingRelated issue/s
How to test
Dev-ops checklist