-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed issue with accumulating tracked services #6631
🐛 Fixed issue with accumulating tracked services #6631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so question, if I get it correctly now you will have these entries for 5 minutes, that trigger an incredible amount of logs. is this really how it is suppose to work? I wonder if that rate of messages is not an overkill.
Thanks
.../dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/service_tracker/_models.py
Outdated
Show resolved
Hide resolved
.../dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/service_tracker/_models.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just have a few questions
.../dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/service_tracker/_models.py
Show resolved
Hide resolved
.../dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/service_tracker/_models.py
Outdated
Show resolved
Hide resolved
.../dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/status_monitor/_monitor.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6631 +/- ##
==========================================
- Coverage 87.61% 87.20% -0.41%
==========================================
Files 1525 765 -760
Lines 60678 36871 -23807
Branches 2085 265 -1820
==========================================
- Hits 53165 32155 -21010
+ Misses 7195 4655 -2540
+ Partials 318 61 -257
Continue to review full report in Codecov by Sentry.
|
@matusdrobuliak66 @pcrespov @sanderegg If you ever need to use Answers to questions that might come out:
I state my case here and revere back for it for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the number of stars is not everything. Nevertheless that shows a bit the usage of a library. so one with 2k stars is probably more used than one with 200. Also when I check that repo, I see Test: No Status, that does not really seem maintained.
Also note the last release is from May 2023.
.../dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/service_tracker/_models.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
Addresses an issue where the dynamic-scheduler will keep track of services which have been stopped but are still tracked as
requested_state=RUNNING
. This can happen if services are manually removed or for other edge cases.♻️ changed the bytes serialised for message-pack which more easily allows for model changes in the future
🐛 services which are reported
IDLE
by the platform and the dynamic-scheduler sees them asrequested_state=RUNNING
will be removed after 5 minutes of inactivity⬆️ upgrade
msgpack
repo wideRelated issue/s
How to test
Dev-ops checklist