Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor RUT (renaming/rearranging/error handling) #6648

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • ♻️ Refactor RUT (prepare basis for additional development)
    • Renaming/rearranging modules/functions
    • Improve error handling

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 1, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 89.82036% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.87%. Comparing base (7d52bf7) to head (91348dd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6648      +/-   ##
==========================================
- Coverage   87.88%   87.87%   -0.01%     
==========================================
  Files        1563     1220     -343     
  Lines       62881    53144    -9737     
  Branches     2088      961    -1127     
==========================================
- Hits        55260    46700    -8560     
+ Misses       7303     6267    -1036     
+ Partials      318      177     -141     
Flag Coverage Δ
integrationtests 64.83% <33.33%> (-0.02%) ⬇️
unittests 85.45% <89.82%> (-0.49%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.71% <ø> (+0.07%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.26% <ø> (ø)
catalog 89.52% <ø> (ø)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.43% <ø> (+0.04%) ⬆️
director_v2 90.85% <ø> (ø)
dynamic_scheduler 96.72% <ø> (ø)
dynamic_sidecar 89.72% <ø> (ø)
efs_guardian 90.00% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 93.09% <ø> (ø)
resource_usage_tracker 90.75% <90.85%> (+3.37%) ⬆️
storage 89.75% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.30% <33.33%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d52bf7...91348dd. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 1, 2024 14:16
@matusdrobuliak66 matusdrobuliak66 added the a:resource-usage-tracker resource usage tracker service label Nov 1, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 1, 2024 16:15
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks great! left some recommendations for this (or next) PR

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify what we discussed I have commented how I perceive this.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I've approved this.

Copy link

sonarqubecloud bot commented Nov 4, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit dac26e1 into ITISFoundation:master Nov 4, 2024
87 of 89 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants