-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Refactor RUT (renaming/rearranging/error handling) #6648
♻️ Refactor RUT (renaming/rearranging/error handling) #6648
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6648 +/- ##
==========================================
- Coverage 87.88% 87.87% -0.01%
==========================================
Files 1563 1220 -343
Lines 62881 53144 -9737
Branches 2088 961 -1127
==========================================
- Hits 55260 46700 -8560
+ Misses 7303 6267 -1036
+ Partials 318 177 -141
Continue to review full report in Codecov by Sentry.
|
…simcore into add-tags-to-rut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
...ages/service-library/src/servicelib/rabbitmq/rpc_interfaces/resource_usage_tracker/errors.py
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/core/application.py
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/handlers/_http_error.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/errors.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 looks great! left some recommendations for this (or next) PR
...ces/web/server/src/simcore_service_webserver/resource_usage/_pricing_plans_admin_handlers.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/errors.py
Outdated
Show resolved
Hide resolved
services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/errors.py
Outdated
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/handlers/_http_error.py
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/handlers/_http_error.py
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/services/background_tasks_setup.py
Outdated
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/exceptions/handlers/_http_error.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions
...-usage-tracker/src/simcore_service_resource_usage_tracker/services/background_tasks_setup.py
Outdated
Show resolved
Hide resolved
...-usage-tracker/src/simcore_service_resource_usage_tracker/services/background_tasks_setup.py
Outdated
Show resolved
Hide resolved
...ces/web/server/src/simcore_service_webserver/resource_usage/_pricing_plans_admin_handlers.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify what we discussed I have commented how I perceive this.
...re_service_resource_usage_tracker/services/background_task_periodic_heartbeat_check_setup.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought I've approved this.
|
dac26e1
into
ITISFoundation:master
What do these changes do?
Related issue/s
How to test
Dev-ops checklist