-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Sync task that auto-registers items from VIP as licensed items in the system 🗃️ 🚨 #7140
✨ Sync task that auto-registers items from VIP as licensed items in the system 🗃️ 🚨 #7140
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7140 +/- ##
==========================================
+ Coverage 87.66% 87.69% +0.03%
==========================================
Files 1636 1634 -2
Lines 63958 63981 +23
Branches 1179 1179
==========================================
+ Hits 56069 56111 +42
+ Misses 7577 7559 -18
+ Partials 312 311 -1
Continue to review full report in Codecov by Sentry.
|
8fac934
to
f266505
Compare
17762ce
to
77be4fc
Compare
5285367
to
5d45c0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the js part looks good to me
services/web/server/src/simcore_service_webserver/licenses/_common/models.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot! 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving without reading to unblock. I am currently fixing a server incident sorry. should be fine :--)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a few minor things
services/web/server/src/simcore_service_webserver/licenses/_itis_vip_syncer_service.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If applicable: don't forget about ENV for STAG / PROD environments
|
What do these changes do?
Fetches models from
vip-api
, validates them, and registers them inlicensed_items
through a periodic background task.licenses
tomodels_library.licenses
LicensedItemRestGet
(refer to OAS above)object
inlicensed_resource_data
with a more specific definition [PINED!]postgres-database
"licensed_resource_name", "licensed_resource_type"
) for resource identificationWEBSERVER_LICENSES
is no longer a flag. To determine if it is disabled, the front-end should refer topluginDisabled
in the statics instead.packages/service-library/src/servicelib/background_task.py
services/api-server/src/simcore_service_api_server/main.py
(required for CLI)services/resource-usage-tracker/docker/boot.sh
Related issue/s
licensed_items
table #7097How to test
Driving tests
Dev-ops
product_name
) and princing plans (pricing_plan_id
)