Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Updates licensed_items table 🗃️ #7144

Merged
merged 10 commits into from
Jan 30, 2025

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 30, 2025

What do these changes do?

🗃️ Alters licensed_item table

  • renames name to licensed_resource_name
  • adds trashed timestamp mark
  • sets product_name, pricing_plan_id as nullable ( when both set, the item is "active")

🎨 Improves repository

  • adds filters for active and trash

🎨 Improves model conversion

  • conversion from domain to rest schema models

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv -ff tests/unit/**/test_license.py

## Dev-ops

@pcrespov pcrespov added this to the Singularity milestone Jan 30, 2025
@pcrespov pcrespov self-assigned this Jan 30, 2025
@pcrespov pcrespov added a:webserver issue related to the webserver service a:database associated to postgres service and postgres-database package a:models-library labels Jan 30, 2025
@pcrespov pcrespov marked this pull request as ready for review January 30, 2025 10:58
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (b50e7e8) to head (1771b1c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7144      +/-   ##
==========================================
+ Coverage   87.70%   88.82%   +1.11%     
==========================================
  Files        1635     1418     -217     
  Lines       63875    56820    -7055     
  Branches     1173      695     -478     
==========================================
- Hits        56022    50469    -5553     
+ Misses       7543     6184    -1359     
+ Partials      310      167     -143     
Flag Coverage Δ
integrationtests 64.66% <15.00%> (-0.08%) ⬇️
unittests 86.90% <92.30%> (+0.90%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.49% <94.11%> (-0.01%) ⬇️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.39% <100.00%> (ø)
pkg_service_integration 70.18% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.50% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 90.33% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 77.01% <ø> (+0.08%) ⬆️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.21% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.84% <ø> (-0.22%) ⬇️
storage 89.57% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.21% <90.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50e7e8...1771b1c. Read the comment docs.

@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Jan 30, 2025
Copy link
Contributor

mergify bot commented Jan 30, 2025

Restarted CI due to failing tests

@pcrespov pcrespov force-pushed the is7097/licensed-items-db branch from ee2bd0e to fc51ade Compare January 30, 2025 12:36
@pcrespov pcrespov enabled auto-merge (squash) January 30, 2025 12:37
@GitHK GitHK removed the 🤖-automerge marks PR as ready to be merged for Mergify label Jan 30, 2025
@pcrespov pcrespov merged commit b837ee0 into ITISFoundation:master Jan 30, 2025
92 of 94 checks passed
@pcrespov pcrespov deleted the is7097/licensed-items-db branch January 30, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package a:models-library a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants