Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licensing endpoints to api check and improve backwards compatibility checks #7157

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Feb 3, 2025

What do these changes do?

ReDoc

  • Add licensing endpoints to api server's openapi.json (to ensure the backwards compatibility check tests them)
  • improve the backwards compatibility tests.

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis requested a review from mguidon February 3, 2025 09:44
@bisgaard-itis bisgaard-itis self-assigned this Feb 3, 2025
@bisgaard-itis bisgaard-itis added the a:apiserver api-server service label Feb 3, 2025
@bisgaard-itis bisgaard-itis added this to the Singularity milestone Feb 3, 2025
@bisgaard-itis bisgaard-itis changed the title Add licensing endpoints to openapi.json and improve backwards compatibility checks Add licensing endpoints to ap check and improve backwards compatibility checks Feb 3, 2025
@bisgaard-itis bisgaard-itis changed the title Add licensing endpoints to ap check and improve backwards compatibility checks Add licensing endpoints to api check and improve backwards compatibility checks Feb 3, 2025
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (a1614e8) to head (d90ab69).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a1614e8) and HEAD (d90ab69). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (a1614e8) HEAD (d90ab69)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7157       +/-   ##
===========================================
- Coverage   87.70%   69.78%   -17.92%     
===========================================
  Files        1635      724      -911     
  Lines       63943    33974    -29969     
  Branches     1178      168     -1010     
===========================================
- Hits        56079    23708    -32371     
- Misses       7552    10209     +2657     
+ Partials      312       57      -255     
Flag Coverage Δ
integrationtests 64.69% <ø> (+0.04%) ⬆️
unittests 90.55% <ø> (+4.55%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.54% <ø> (-7.96%) ⬇️
agent ∅ <ø> (∅)
api_server 90.55% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.61% <ø> (-12.66%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.27% <ø> (-26.92%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1614e8...d90ab69. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.
I took the liberty to add the badge so it is more clear to explore the changes

@bisgaard-itis
Copy link
Contributor Author

Thx. I took the liberty to add the badge so it is more clear to explore the changes

Thanks a lot

Copy link

sonarqubecloud bot commented Feb 3, 2025

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) February 3, 2025 10:36
@bisgaard-itis bisgaard-itis merged commit e970143 into ITISFoundation:master Feb 3, 2025
90 of 94 checks passed
@bisgaard-itis bisgaard-itis deleted the 7099-improve-backwards-compatibility-checks branch February 3, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve backwards compatibility CI checks Backward Compatibility Tests for the API
3 participants