Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› error handling vip models πŸ—ƒοΈ #7184

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Feb 7, 2025

What do these changes do?

  • Fixes πŸ› (reported by @mguidon)
    • wrong num of available seats when over the limit
    • when wrong service_run_id provided returns 500 --> not true returns 422 (the 500 was probably caused by redeployment of master)
  • Make email mandatory in licensed checkouts and purchases (πŸ—ƒοΈ)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 added the bug buggy, it does not work as expected label Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 89.27%. Comparing base (eee4eb2) to head (6f3eee1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7184      +/-   ##
==========================================
+ Coverage   87.71%   89.27%   +1.55%     
==========================================
  Files        1641     1400     -241     
  Lines       64177    55874    -8303     
  Branches     1179      624     -555     
==========================================
- Hits        56293    49880    -6413     
+ Misses       7573     5847    -1726     
+ Partials      311      147     -164     
Flag Coverage Ξ”
integrationtests 68.59% <ΓΈ> (-10.64%) ⬇️
unittests 87.44% <100.00%> (+1.33%) ⬆️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library 91.49% <ΓΈ> (ΓΈ)
pkg_notifications_library 84.57% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.39% <ΓΈ> (ΓΈ)
pkg_service_integration βˆ… <ΓΈ> (βˆ…)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 85.50% <ΓΈ> (ΓΈ)
agent 96.46% <ΓΈ> (ΓΈ)
api_server 90.55% <100.00%> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 91.47% <ΓΈ> (ΓΈ)
clusters_keeper 99.24% <ΓΈ> (ΓΈ)
dask_sidecar 91.26% <ΓΈ> (ΓΈ)
datcore_adapter 93.19% <ΓΈ> (ΓΈ)
director 76.92% <ΓΈ> (ΓΈ)
director_v2 91.27% <ΓΈ> (-0.02%) ⬇️
dynamic_scheduler 97.17% <ΓΈ> (ΓΈ)
dynamic_sidecar 89.75% <ΓΈ> (ΓΈ)
efs_guardian 90.25% <ΓΈ> (ΓΈ)
invitations 93.28% <ΓΈ> (ΓΈ)
osparc_gateway_server βˆ… <ΓΈ> (βˆ…)
payments 92.66% <ΓΈ> (ΓΈ)
resource_usage_tracker 89.01% <ΓΈ> (+0.05%) ⬆️
storage 89.57% <ΓΈ> (ΓΈ)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 86.29% <ΓΈ> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update eee4eb2...6f3eee1. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: πŸ› error handling vip models πŸ› error handling vip models πŸ—ƒοΈ Feb 7, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 7, 2025 12:50
Copy link

sonarqubecloud bot commented Feb 7, 2025

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 7, 2025 12:52
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€

@matusdrobuliak66 matusdrobuliak66 merged commit 70e88e8 into ITISFoundation:master Feb 7, 2025
92 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Null user_email licensed_items_purchases_db raises validation error when listing purchaes
4 participants