-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ introduce licensed_resources
(🗃️)
#7190
♻️ introduce licensed_resources
(🗃️)
#7190
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7190 +/- ##
==========================================
+ Coverage 87.03% 88.25% +1.22%
==========================================
Files 1644 1425 -219
Lines 64231 57057 -7174
Branches 1186 699 -487
==========================================
- Hits 55901 50356 -5545
+ Misses 8018 6533 -1485
+ Partials 312 168 -144
Continue to review full report in Codecov by Sentry.
|
licensed_resources
licensed_resources
(🗃️)
services/web/server/src/simcore_service_webserver/licenses/_licensed_resources_repository.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…o vip-models-split-licensed-items-2-attempt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py
Outdated
Show resolved
Hide resolved
|
7457535
into
ITISFoundation:master
What do these changes do?
licensed_resources
(🗃️)The same license can have multiple VIP models bundled together. Therefore, we need to extend the logic of
licensed_items
to support this use case. This PR is the first small step toward achieving that.Related issue/s
How to test
Dev-ops checklist