-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 migration fix (🗃️) #7216
🐛 migration fix (🗃️) #7216
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Greatly appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
...base/src/simcore_postgres_database/migration/versions/68777fdf9539_add_licensed_resources.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7216 +/- ##
==========================================
+ Coverage 85.39% 86.79% +1.39%
==========================================
Files 1654 1407 -247
Lines 64435 55938 -8497
Branches 1095 530 -565
==========================================
- Hits 55027 48553 -6474
+ Misses 9095 7238 -1857
+ Partials 313 147 -166
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a bit puzzled by how it's supposed to work on a db where this was already executed.
What do these changes do?
🐛 Previous code, when running automatic migration would create a new migration script that would change the behaviour of that ENUM. Using
postgresql.ENUM
solved the issue.Related issue/s
How to test
Dev-ops checklist