Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 migration fix (🗃️) #7216

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Feb 12, 2025

What do these changes do?

🐛 Previous code, when running automatic migration would create a new migration script that would change the behaviour of that ENUM. Using postgresql.ENUM solved the issue.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 12, 2025 13:10
@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 12, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 12, 2025 13:13
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Greatly appreciated!

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (b0edf43) to head (2509e6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7216      +/-   ##
==========================================
+ Coverage   85.39%   86.79%   +1.39%     
==========================================
  Files        1654     1407     -247     
  Lines       64435    55938    -8497     
  Branches     1095      530     -565     
==========================================
- Hits        55027    48553    -6474     
+ Misses       9095     7238    -1857     
+ Partials      313      147     -166     
Flag Coverage Δ
integrationtests 65.32% <ø> (-0.02%) ⬇️
unittests 85.98% <ø> (+0.15%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.53% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.25% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.55% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.71% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 93.19% <ø> (ø)
director 76.59% <ø> (-0.10%) ⬇️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 88.84% <ø> (-0.33%) ⬇️
storage 86.34% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 79.36% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0edf43...2509e6f. Read the comment docs.

@pcrespov pcrespov requested a review from GitHK February 12, 2025 13:26
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a bit puzzled by how it's supposed to work on a db where this was already executed.

@pcrespov pcrespov disabled auto-merge February 12, 2025 13:37
@pcrespov pcrespov enabled auto-merge (squash) February 12, 2025 13:37
@pcrespov pcrespov disabled auto-merge February 12, 2025 13:40
@pcrespov pcrespov merged commit 62c8a09 into ITISFoundation:master Feb 12, 2025
91 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants