Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] ViP Market: Support 0-cost models #7245

Merged
merged 9 commits into from
Feb 18, 2025
Merged

🎨 [Frontend] ViP Market: Support 0-cost models #7245

merged 9 commits into from
Feb 18, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 18, 2025 •
edited
Loading

What do these changes do?

This PR adds features to handle LicensedItems with a 0-cost plan.

  • A "Included Items" "Open Access Models" category was added that will list all those "free" items
  • The free items, same as the Rented items, will also be shown in their own category
  • The free items don't get a "Rent" option, they show "Available for Importing" text instead

Bonus:

  • Try to handle models with no name: try to extract it from the description....
  • Bugfix: multiple purchases

NoCost

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Feb 18, 2025
@odeimaiz odeimaiz added this to the Singularity milestone Feb 18, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Feb 18, 2025
@odeimaiz odeimaiz marked this pull request as ready for review February 18, 2025 15:57
@mguidon
Copy link
Member

mguidon commented Feb 18, 2025

What about "Open Access Models"?

@odeimaiz
Copy link
Member Author

What about "Open Access Models"?

done

sanderegg
sanderegg reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) February 18, 2025 16:32
@odeimaiz odeimaiz disabled auto-merge February 18, 2025 16:41
@odeimaiz odeimaiz enabled auto-merge (squash) February 18, 2025 17:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit cb26eab into ITISFoundation:master Feb 18, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@ignapas ignapas Awaiting requested review from ignapas

@GitHK GitHK Awaiting requested review from GitHK

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Singularity
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @mguidon @pcrespov @sanderegg @matusdrobuliak66