-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mnemonic sentence support #975
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I want feedback from the rest of the team before we approve and merge.
cardano-cli/test/cardano-cli-golden/files/golden/help/shelley_key_key-from-mnemonic.cli
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/files/golden/help/allegra_key.cli
Outdated
Show resolved
Hide resolved
This PR is stale because it has been open 45 days with no activity. |
Update stanza
9dd7301
to
eab669b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I just have one concern regarding haskeline
. If we don't need it lets not use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 . One final question.
60eaa1c
to
7c61f48
Compare
Changelog
Context
This PR is associated to: IntersectMBO/cardano-api#678.
It is part of an effort to integrate
cardano-addresses
functionalities into thecardano-cli
.How to trust this PR
I would look mainly at the logic, the changes in the help golden files, and probably testing it is the best way.
Checklist