Addition of Conway Tests related to delegation changes, drep multiple registration, deposit returns. #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to User stories PR : IntersectMBO/cardano-test-plans#45 After the review and merge of User Stories, This PR should be updated to facilitate the test status on the Cardano-node-tests dashboard. |
This was referenced Jun 18, 2024
nabinpkl
force-pushed
the
extra-conway-tests
branch
2 times, most recently
from
a2370b4 to
e9724ac
Compare
nabinpkl
force-pushed
the
extra-conway-tests
branch
from
e9724ac to
8518bab
Compare
saratomaz
reviewed
Jun 19, 2024
saratomaz
reviewed
Jun 19, 2024
saratomaz
reviewed
Jun 19, 2024
saratomaz
reviewed
Jun 19, 2024
|
It would be nice to have the tests in the correspondent files, like drep tests should be in |
nabinpkl
force-pushed
the
extra-conway-tests
branch
2 times, most recently
from
abbfd28 to
87b3301
Compare
nabinpkl
changed the title
Thank you for the review. Respective changes are added to respective files in the latest update. |
nabinpkl
force-pushed
the
extra-conway-tests
branch
2 times, most recently
from
698f343 to
5de871e
Compare
nabinpkl
changed the title
nabinpkl
changed the title
nabinpkl
force-pushed
the
extra-conway-tests
branch
3 times, most recently
from
402f591 to
4825d80
Compare
nabinpkl
force-pushed
the
extra-conway-tests
branch
from
4825d80 to
89de998
Compare
|
This PR has been updated and rebased with the latest changes. User stories also have been merged. Can you have a look at it whether it can be merged? |
mkoura
requested changes
Jul 9, 2024
mkoura
reviewed
Jul 9, 2024
mkoura
reviewed
Jul 9, 2024
mkoura
reviewed
Jul 9, 2024
mkoura
reviewed
Jul 9, 2024
- blake2b_224 of drep id - delegation change - no multiple delegation - delegation without stake registration - drep no multiple registration - drep no retirement before register
nabinpkl
force-pushed
the
extra-conway-tests
branch
from
89de998 to
ab2c117
Compare
mkoura
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Conway tests which are not already covered on existing test topics are: