Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chairman socket dir #574

Closed
coot opened this issue Feb 17, 2020 · 1 comment
Closed

chairman socket dir #574

coot opened this issue Feb 17, 2020 · 1 comment
Assignees
@coot
Labels
bug Something isn't working chairman Issues related to chairman application

Comments

@coot
Copy link
Contributor

coot commented Feb 17, 2020

I think there's a bug how chairman is treating the socket dir.

here createConnection is called with socketDir which should be socketFp (.e.g. scoketDir ++ "/" ++ show coreNodeId (or something similar).
@coot coot added the bug Something isn't working label Feb 17, 2020
@coot coot assigned Jimbo4350 and coot and unassigned Jimbo4350 Feb 17, 2020
coot added a commit that referenced this issue Feb 17, 2020
@coot
Fix #574: chairman socket path
805df21 
Chairman --socket-path argument can be given multiple times.  It
indicates to which unix sockets to connect to (and check for consensus).

Chairman now identifies nodes by `SocketPath`, `CoreNodeId` is
not used now, maybe it can be removed from `ourobors-consensus` as well.

Nix scripts are not updated, and need to accomodate for chairman CLI
changes.
@coot coot added the chairman Issues related to chairman application label Feb 17, 2020
@iohk-bors iohk-bors bot closed this as completed in 6d6a9d6 Feb 17, 2020
@coot
Copy link
Contributor Author

coot commented Feb 18, 2020

Fixed in 6d6a9d6

@coot coot added this to the S7 2020-02-27 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coot coot

Labels
bug Something isn't working chairman Issues related to chairman application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coot @Jimbo4350