Remove dependency on cardano-ledger-test #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not needed anymore, and it involved a dependency on the cardano-ledger-test package, which the cli and node should not have to depend on.
The cardano-node should not depend on test packages. Also, it just so happened that the ledger test package indirectly depends on a package (typerep-map) that does not currently build on 32bit systems (like many ARM systems), and removing this dependency is the last thing needed to get the node to build on a RPi4/Raspbian.
iohk-bors bot
added a commit
that referenced
this pull request
Jan 5, 2020
451: Remove dependency on cardano-ledger-test r=deepfire a=dcoutts The cardano-node should not depend on test packages. Also, it just so happened that the ledger test package indirectly depends on a package (typerep-map) that does not currently build on 32bit systems (like many ARM systems), and removing this dependency is the last thing needed to get the node to build on a RPi4/Raspbian. This involves removing the `cardano-cli dump-hardcoded-genesis` subcommand. It is not needed anymore, and it involved a dependency on the cardano-ledger-test package. Co-authored-by: Duncan Coutts <[email protected]>
Canceled |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 5, 2020
451: Remove dependency on cardano-ledger-test r=dcoutts a=dcoutts The cardano-node should not depend on test packages. Also, it just so happened that the ledger test package indirectly depends on a package (typerep-map) that does not currently build on 32bit systems (like many ARM systems), and removing this dependency is the last thing needed to get the node to build on a RPi4/Raspbian. This involves removing the `cardano-cli dump-hardcoded-genesis` subcommand. It is not needed anymore, and it involved a dependency on the cardano-ledger-test package. Co-authored-by: Duncan Coutts <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cardano-node should not depend on test packages.
Also, it just so happened that the ledger test package indirectly depends on a package (typerep-map) that does not currently build on 32bit systems (like many ARM systems), and removing this dependency is the last thing needed to get the node to build on a RPi4/Raspbian.
This involves removing the
cardano-cli dump-hardcoded-genesissubcommand. It is not needed anymore, and it involved a dependency on the cardano-ledger-test package.