Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-371 trace acceptor removed #454

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Jan 6, 2020

the logging framework does not contain the trace forwarder/acceptor anymore; kept in a plugin which can be loaded separately.

depends on input-output-hk/iohk-monitoring-framework#498

^^ upstream PR merged

@CodiePP CodiePP added the WIP Work In Progress (cannot be merged yet) label Jan 6, 2020
@CodiePP CodiePP added this to the S4 2020-01-16 milestone Jan 6, 2020
@CodiePP CodiePP removed the WIP Work In Progress (cannot be merged yet) label Jan 7, 2020
@CodiePP CodiePP requested a review from mrBliss January 7, 2020 16:17
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, removing the federated logging from node to LM.

mkdir -p logs/

PWD=$(pwd)

tmux split-window -v
tmux select-pane -t 0
#tmux split-window -v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So opening 4 tmux windows instead of 5?

@CodiePP
Copy link
Contributor Author

CodiePP commented Jan 8, 2020

@ksaric removed all the mentioning of '#messagecounters' in configurations.

@CodiePP CodiePP force-pushed the cad-371-trace-acceptor-removed branch from 2bb98fa to 9aed74e Compare January 8, 2020 14:06
@CodiePP
Copy link
Contributor Author

CodiePP commented Jan 8, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 8, 2020
454: CAD-371 trace acceptor removed r=CodiePP a=CodiePP

the logging framework does not contain the trace forwarder/acceptor anymore; kept in a plugin which can be loaded separately.


~depends on input-output-hk/iohk-monitoring-framework#498

^^ upstream PR merged


Co-authored-by: Alexander Diemand <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 8, 2020

@iohk-bors iohk-bors bot merged commit 9aed74e into master Jan 8, 2020
@iohk-bors iohk-bors bot deleted the cad-371-trace-acceptor-removed branch January 8, 2020 14:53
@CodiePP CodiePP added the byron Required for a Byron mainnet: replace the old core nodes with cardano-node. label Jan 13, 2020
@CodiePP CodiePP self-assigned this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
byron Required for a Byron mainnet: replace the old core nodes with cardano-node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants