Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-384: add mempoolBytes metric #457

Merged
merged 2 commits into from
Jan 13, 2020
Merged

CAD-384: add mempoolBytes metric #457

merged 2 commits into from
Jan 13, 2020

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jan 9, 2020 •
edited
Loading

  1. Expose the mempool size (in bytes) as a new metric.
  2. Add the metric to the TUI LiveView interface
  3. A bit more order in the trace hierarchy.

@deepfire deepfire added the enhancement New feature or request label Jan 9, 2020
@deepfire deepfire added this to the S4 2020-01-16 milestone Jan 9, 2020
@deepfire deepfire self-assigned this Jan 9, 2020
@deepfire deepfire requested review from Jimbo4350 and CodiePP January 9, 2020 12:39
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from a941cda to 2ecbd01 Compare January 9, 2020 13:01
@deepfire deepfire changed the title CAD-384: add txsMempoolBytes metric CAD-384: add mempoolBytes metric Jan 9, 2020
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch 4 times, most recently from 9e9d3dc to 28b8ccd Compare January 9, 2020 14:02
CodiePP
CodiePP reviewed Jan 9, 2020
View reviewed changes
CodiePP
CodiePP reviewed Jan 9, 2020
View reviewed changes
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from 28b8ccd to 83c11b5 Compare January 9, 2020 15:17
CodiePP
CodiePP reviewed Jan 9, 2020
View reviewed changes
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from 83c11b5 to 88549ea Compare January 9, 2020 18:17
deepfire added a commit to input-output-hk/iohk-nix that referenced this pull request Jan 10, 2020
@deepfire
generic-log-config: update, in accord with IntersectMBO/cardano-node#457
b05ffcb
@deepfire deepfire mentioned this pull request Jan 10, 2020
Closed
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from 59472b5 to a9ec0ca Compare January 10, 2020 16:11
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from a9ec0ca to 8972e32 Compare January 10, 2020 16:12
deepfire added a commit to input-output-hk/iohk-nix that referenced this pull request Jan 10, 2020
@deepfire
generic-log-config: update, in accord with IntersectMBO/cardano-node#457
5238546
@CodiePP CodiePP requested a review from disassembler January 10, 2020 16:35
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from 9c28329 to 59ceb04 Compare January 10, 2020 16:36
@deepfire deepfire force-pushed the cad-384-mempool-bytes branch 2 times, most recently from ae47ee3 to cb8d655 Compare January 10, 2020 20:40
@deepfire
Copy link
Contributor Author

Screenshot from 2020-01-13 13-26-41
..is the updated Live View.

@deepfire deepfire force-pushed the cad-384-mempool-bytes branch from cb8d655 to 3a933f1 Compare January 13, 2020 10:40
CodiePP
CodiePP approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@CodiePP CodiePP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@CodiePP
Copy link
Contributor

CodiePP commented Jan 13, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 13, 2020
@iohk-bors @deepfire
Merge #457
8d53169 
457: CAD-384:  add mempoolBytes metric r=CodiePP a=deepfire

1. Expose the mempool size (in bytes) as a new metric.
2. Add the metric to the TUI LiveView interface
3. A bit more order in the trace hierarchy.

Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 13, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 3a933f1 into master Jan 13, 2020
@iohk-bors iohk-bors bot deleted the cad-384-mempool-bytes branch January 13, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodiePP CodiePP CodiePP approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@disassembler disassembler Awaiting requested review from disassembler

Assignees

@deepfire deepfire

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepfire @CodiePP