Update TraceForgeEvent logging details
#537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may want to remove the "txid" string from the |
CodiePP
suggested changes
Feb 4, 2020
| toObject _verb (TraceAdoptedBlock slotNo _blk _txs) = | ||
| instance (HasTxId tx, ProtocolLedgerView blk, Condense (HeaderHash blk), Show (TxId tx)) | ||
| => ToObject (TraceForgeEvent blk tx) where | ||
| toObject _verb (TraceAdoptedBlock slotNo blk txs) = |
There was a problem hiding this comment.
we should probably print the list of transaction ids only if _verb == 'MaximumVerbosity'
can potentially be huge!
There was a problem hiding this comment.
@CodiePP changes made
… txids in that block Update the following tracers to Error severity: TraceNoLedgerState TraceNoLedgerView TraceBlockFromFuture TraceDidntAdoptBlock TraceForgedInvalidBlock
Jimbo4350
force-pushed
the
jordan/block-forging-tracing-default-log-level
branch
from
8fbdf09 to
f11f46d
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 5, 2020
537: Update `TraceForgeEvent` logging details r=Jimbo4350 a=Jimbo4350
- Update tracer `TraceAdoptedBlock` to log the block hash and a list of txids in that block.
Example output: `[cardano.node.Forge:Info:61] [2020-02-04 18:08:26.00 UTC] {"kind":"TraceAdoptedBlock","slot":6,"tx ids":"[txid: txid:6875a2f9]","block hash":"a6d8325832257989"}`
- Update the following tracers to `Error` severity:
`TraceNoLedgerState`
`TraceNoLedgerView`
`TraceBlockFromFuture`
`TraceDidntAdoptBlock`
`TraceForgedInvalidBlock`
Relevant issue: #528
Co-authored-by: Jordan Millar <[email protected]>
Build succeeded |
iohk-bors
bot
deleted the
jordan/block-forging-tracing-default-log-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceAdoptedBlockto log the block hash and a list of txids in that block.Example output:
[cardano.node.Forge:Info:61] [2020-02-04 18:08:26.00 UTC] {"kind":"TraceAdoptedBlock","slot":6,"tx ids":"[txid: txid:6875a2f9]","block hash":"a6d8325832257989"}Errorseverity:TraceNoLedgerStateTraceNoLedgerViewTraceBlockFromFutureTraceDidntAdoptBlockTraceForgedInvalidBlockRelevant issue: #528