Mempool event tracing details at default log level #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
commented
Feb 4, 2020
Comment on lines
859
to
860
| , "txsAdded" .= String (pack $ show $ txs) | ||
| , "mempoolSize" .= String (pack $ show $ mpSz) |
There was a problem hiding this comment.
Using show here probably isn't so great.
@CodiePP: Should I introduce some additional ToObject instances for the required types or is this sufficient?
CodiePP
approved these changes
Feb 5, 2020
intricate
changed the title
intricate
force-pushed
the
intricate/527
branch
from
abd9a11 to
2f2df7c
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 6, 2020
538: Mempool event tracing details at default log level r=intricate a=intricate Related: #527 Co-authored-by: Luke Nadur <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #527