-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAD-426 Tx gen: submit transactions to Explorer's WebAPI. #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
reviewed
Feb 7, 2020
erikd
reviewed
Feb 7, 2020
erikd
requested changes
Feb 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes in comments.
ef44633
to
b9624b9
Compare
erikd
approved these changes
Feb 7, 2020
49273f5
to
a25e3a8
Compare
CodiePP
reviewed
Feb 11, 2020
CodiePP
reviewed
Feb 11, 2020
CodiePP
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good documentation
just minor issues raised.
a25e3a8
to
bed2e44
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 11, 2020
549: CAD-426 Tx gen: submit transactions to Explorer's WebAPI. r=CodiePP a=denisshevchenko We need a way to test the transaction submission POST API in the explorer (`cardano-tx-submit-webapi` executable). Please see [Testing cardano-tx-submit-webapi](https://github.com/input-output-hk/cardano-explorer/blob/master/cardano-tx-submit/testing-tx-submit.md) for current workflow. Co-authored-by: Denis Shevchenko <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way to test the transaction submission POST API in the explorer (
cardano-tx-submit-webapi
executable). Please see Testing cardano-tx-submit-webapi for current workflow.