Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAD-508: rename the serialised blockfetch trace to BlockFetchProtocolSerialised #670

Merged
merged 1 commit into from
Mar 12, 2020
Merged

CAD-508: rename the serialised blockfetch trace to BlockFetchProtocolSerialised #670

merged 1 commit into from
Mar 12, 2020

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Mar 12, 2020 •
edited
Loading

  1. rename the serialised blockfetch trace from BlockFetchProtocol to BlockFetchProtocolSerialised -- so one who wants semantic messages is not necessarily flooded by raw message dumps.
  • This PR does not result in breaking changes to upstream dependencies.

Checklist

  • This PR contains all the work required to resolve the linked issue.

  • The work contained has sufficient documentation to describe what it does and how to do it.

  • The work has sufficient tests and/or testing.

  • I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

  • I have added the appropriate labels to this PR.

@deepfire deepfire requested review from Jimbo4350, CodiePP, karknu and coot and removed request for Jimbo4350 March 12, 2020 09:33
@CodiePP CodiePP requested a review from Jimbo4350 March 12, 2020 09:36
karknu
karknu approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@deepfire
Copy link
Contributor Author

bors r+

@deepfire deepfire added maintenance Non-critical improvement or maintenance tasks. priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai labels Mar 12, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 12, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit f022a55 into master Mar 12, 2020
@iohk-bors iohk-bors bot deleted the cad-508-rename-trace branch March 12, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karknu karknu karknu approved these changes

@CodiePP CodiePP Awaiting requested review from CodiePP

@coot coot Awaiting requested review from coot

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees
No one assigned
Labels
maintenance Non-critical improvement or maintenance tasks. priority low Issues/RPs that are low priority issues/PRs in relation to a minimum Shelley testnet and Shelley mai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepfire @karknu