CAD-792: bump monitoring for non-API-breaking efficiency improvements #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
added
maintenance
|
Nice. So this PR will need to wait for that PR to be merged to |
Yes, sorry, should have made this a draft PR. |
deepfire
force-pushed
the
cad-792-api-free-monitoring-speedup
branch
from
8bf8bf7 to
3e12e40
Compare
deepfire
force-pushed
the
cad-792-api-free-monitoring-speedup
branch
from
3e12e40 to
ad31048
Compare
erikd
approved these changes
Apr 23, 2020
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 23, 2020
831: CAD-792: bump monitoring for non-API-breaking efficiency improvements r=deepfire a=deepfire 1. The new `iohk-monitoring` preserves more laziness, see: input-output-hk/iohk-monitoring-framework#550 - The performance impact is described in CAD-792 -- roughly a 10% reduction in wallclock for a locally-served chainsync benchmark. 1. Some minor API sync. 1. More improvements coming soon in a subsequent PR.. API breaking, though. #### TODO - [x] merge input-output-hk/iohk-monitoring-framework#550 - This PR **does not result** in breaking changes to upstream dependencies. Checklist --------- - [ ] This PR contains all the work required to resolve the linked issue. - [ ] The work contained has sufficient documentation to describe what it does and how to do it. - [x] The work has sufficient tests and/or testing. - [x] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these. - [x] I have added the appropriate labels to this PR. Co-authored-by: Kosyrev Serge <[email protected]>
Canceled |
|
bors merge Had to push a fix for the CI failure -- the changes in strictness apparently exposed a latent bug fixed by the last commit, which was made obvious by the non-default configuration: |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
iohk-monitoringpreserves more laziness, see: CAD-792: non-API-breaking efficiency optimisations input-output-hk/iohk-monitoring-framework#550Some minor API sync.
More improvements coming soon in a subsequent PR.. API breaking, though.
TODO
merge CAD-792: non-API-breaking efficiency optimisations input-output-hk/iohk-monitoring-framework#550
This PR does not result in breaking changes to upstream dependencies.
Checklist
This PR contains all the work required to resolve the linked issue.
The work contained has sufficient documentation to describe what it does and how to do it.
The work has sufficient tests and/or testing.
I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.
I have added the appropriate labels to this PR.