Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Inconsistent Voting Status Causing Re-Vote on Governance Actions #1713

Closed
kneerose opened this issue Aug 9, 2024 · 2 comments · Fixed by #2433
Closed

[BUG] Inconsistent Voting Status Causing Re-Vote on Governance Actions #1713

kneerose opened this issue Aug 9, 2024 · 2 comments · Fixed by #2433
Assignees
@MSzalowski
Labels
🐛 Bug Something isn't working
Milestone
🏛 Needed for Full...

Comments

@kneerose
Copy link
Contributor

kneerose commented Aug 9, 2024 •
edited
Loading

Context & versions

  • Sometimes, the current vote status is not rendered correctly after changing the vote on a governance action. This causes the test "5E. Should re-vote with new data on an already voted governance action" to become flaky.

Steps to reproduce

Allure report references

  1. Report 1
  2. Report 2
  3. Report 3
@kneerose kneerose added the 🐛 Bug Something isn't working label Aug 9, 2024
@kneerose kneerose mentioned this issue Aug 9, 2024
Open
14 tasks
@kneerose kneerose changed the title [BUG] Inconsistent Vote Status Rendering Causes Flakiness in Re-Vote Tests on Governance Actions [BUG] Inconsistent Voting Status Causing Re-Vote on Governance Actions Aug 9, 2024
@jdyczka jdyczka moved this to In progress in Govtool all Aug 9, 2024
@kneerose
Copy link
Contributor Author

kneerose commented Sep 3, 2024

@jdyczka any update on this ? Could not able to test due to #1910

@kneerose
Copy link
Contributor Author

@jdyczka any update on this? It is still reproducing.

@bosko-m bosko-m moved this from In progress to To do in Govtool all Nov 6, 2024
@MSzalowski MSzalowski assigned MSzalowski and unassigned jdyczka Nov 12, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Nov 25, 2024
MSzalowski added a commit that referenced this issue Nov 27, 2024
@MSzalowski
fix(#1713): fix inconsistent voting status
29070f2
@MSzalowski MSzalowski mentioned this issue Nov 27, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Nov 27, 2024 that will close this issue
fix(#1713): fix inconsistent voting status #2433
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Nov 27, 2024
MSzalowski added a commit that referenced this issue Nov 27, 2024
@MSzalowski
fix(#1713): fix inconsistent voting status
fd85bcf
MSzalowski added a commit that referenced this issue Nov 28, 2024
@MSzalowski
fix(#1713): fix inconsistent voting status
f68bc44
MSzalowski added a commit that referenced this issue Nov 29, 2024
@MSzalowski
fix(#1713): fix inconsistent voting status
e68c943
MSzalowski added a commit that referenced this issue Nov 29, 2024
@MSzalowski
Merge pull request #2433 from IntersectMBO/fix/1713-bug-inconsistent-…
5d433b7 
…voting-status-causing-re-vote-on-governance-actions

fix(#1713): fix inconsistent voting status
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working
Projects
Govtool all
Archived in project
Milestone
🏛 Needed for Full governance / Mainnet
Development

Successfully merging a pull request may close this issue.

fix(#1713): fix inconsistent voting status IntersectMBO/govtool
4 participants
@jdyczka @MSzalowski @kneerose @bosko-m