Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Sync your fork with upstream changes #12

Closed
Greg-21 opened this issue Oct 24, 2024 · 2 comments
Closed

[Suggestion] Sync your fork with upstream changes #12

Greg-21 opened this issue Oct 24, 2024 · 2 comments

Comments

@Greg-21
Copy link

Greg-21 commented Oct 24, 2024

Given that the version 1.21.1 has a good chance of becoming the most popular version in the 1.21.x line among players of modded Minecraft, which is something that the NeoForged Team itself also encourages (source), see:

With Minecraft’s new development policy, minor updates often come with large internal technical changes. These changes are great, and usually benefit modders in the long run. However, they also fragment the community because not all mods are ported or can be ported immediately.

To avoid that fragmentation, we recommend that modders continue to actively maintain the 1.21.1 version of their mods until the release of Minecraft 1.22. Of course, we encourage modders who have the time to also try out and release their mods for 1.21.2 too, and we need their feedback to continue improving NeoForge!

I would really appreciate it if my work, originally submitted in TheIllusiveC4#441 to the upstream repository some time ago and recently accepted and merged, was also included in Adorned for 1.21.1 and later versions.

In such circumstances, may I ask you to sync your fork with the upstream so that my recent update to the Polish translation is also pulled into your repository? According to GitHub, your fork is 2 commits behind, and those are the commits related to my recent work.

@JaisDK
Copy link

JaisDK commented Oct 24, 2024

of course I will, I regularly sync with upstream when it has changes

@Greg-21
Copy link
Author

Greg-21 commented Jan 17, 2025

Considering that the merge was performed in the opposite direction in TheIllusiveC4/Curios@3ad991c, I don't think this is necessary anymore. Therefore, I am closing this suggestion.

@Greg-21 Greg-21 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants