Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish translation update #11

Closed
wants to merge 1 commit into from

Conversation

Greg-21
Copy link

@Greg-21 Greg-21 commented Oct 19, 2024

Given that the release of the stable version 1.21.2 is approaching quickly, likely happening next week (with NeoForge 21.2 following shortly after), and that the current version 1.21.1 has a good chance of becoming the most popular version in the 1.21.x line among players of modded Minecraft, I would really appreciate it if my work, originally submitted in TheIllusiveC4#441 to the upstream repository nearly 2 months ago and still awaiting review (!), was included in Adorned for version 1.21.1 as soon as possible. And the best way to make this happen in time is to contribute directly to the fork in question rather than waiting for TheIllusiveC4 to accept it and then for you to pull it into your fork from upstream at some point. So here I am. I WAS VERY WRONG!

For the sake of completeness, I'll briefly summarize the changes. In this pull request, I updated the Polish translation to include all the changes to the source translation strings made since my last update of the Polish translation 2 years ago in commit a52e7ee. I also took the opportunity to improve some of the existing text strings to ensure the highest possible standards of the translations I maintain.

I would also like to point out that since your fork of the Curios API is not the only popular one for recent Minecraft versions but one of two, this pull request also has a counterpart in SSKirillSS#19 submitted to the other fork. Given that it's still unclear which of your forks will ultimately become the "go-to" replacement for the original Curios API, I decided to contribute to both projects for now.

@Greg-21
Copy link
Author

Greg-21 commented Oct 24, 2024

Given that the updated Polish translation is now available upstream, this PR has been superseded by #12.

@Greg-21 Greg-21 closed this Oct 24, 2024
@Greg-21 Greg-21 deleted the adorned/Polish-T9N branch October 24, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant