Resolve method ambiguities #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
reviewed
Jun 10, 2021
dkarrasch
reviewed
Jun 10, 2021
|
@dkarrasch can I ask you a slightly different question: what do I need to do to trigger CI and codecov to run here? It ran as expected on one of my earlier commits, but hasn't run for the more recent commits... |
|
I think you may have found a giant block of completely obsolete code (in LA.jl), see my PR above for a possible removal. Not sure how much you would benefit from that in the short term. Honestly, I don't know what is wrong with CI. Is it running but not showing on the webpage? |
|
@dkarrasch, i clicked the wrong icon and may have re-requested a review from you. please ignore... still a WIP here :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that having
LinearMapAMbe a subtype ofAbstractMatrixrequires care to avoid these ambiguities.This will probably lead to decreased code coverage so more tests will be needed...