Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jl-mat pairs #100

Merged
merged 1 commit into from
Jun 1, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 47 additions & 17 deletions doc/matlab-to-julia.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@

Many of the functions in MIRT.jl were converted from corresponding
functions in the
[Matlab version of MIRT](https://github.com/JeffFessler/mirt/tree/master)
[Matlab version of MIRT](https://github.com/JeffFessler/mirt/tree/master).

Studying them can be helpful for planning translations of other Matlab functions.
Studying them can be helpful
for planning translations of other Matlab functions.
The languages have many similarities,
but also many dramatic differences
(especially multiple dispatch)
so automatic translation
seems impossible
and one must really understand the algorithm
to do a good conversion.

Here is a list of Julia functions that have direct counter-parts
in Matlab MIRT directories of the same base name:
Expand All @@ -18,31 +26,53 @@ in Matlab MIRT directories of the same base name:
* `fbp/rect_sino.jl`
* `fbp/sino_geom.jl`

Here are some that come from MIRT files in different directories:
Here are some pairs
that came from MIRT files in different directories:

* `io/fld-read.jl` <- `utilities/fld_read.m`
* `io/fld-write.jl` <- `utilities/fld_write.m`
* `mri/sensemap-sim.jl` <- `mri/mri_sensemap_sim.m`
* `mri/kspace.jl` <- `ir_mri_kspace_ga_radial.m`
* `nufft/dtft.jl` <- `nufft/dtft.m`
* `regularize/Aodwt.jl` <- `penalty/Godwt1.m`
* `utility/mask.jl` <- `utility/masker.m` `utility/embed.m`
| Julia | Matlab |
| :-- | :-- |
| [`AVSfldIO/fld-read.jl`][fld-read-jl] | [`utilities/fld_read.m`][fld-read-mat] |
| [`AVSfldIO/fld-write.jl`][fld-write-jl] | [`utilities/fld_write.m`][fld-write-mat] |
| [`mri/sensemap-sim.jl`][sensemap-sim-jl] | [`mri/mri_sensemap_sim.m`][sensemap-sim-mat] |
| [`mri/kspace.jl`][kspace-jl] | [`mri/ir_mri_kspace_ga_radial.m`][kspace-mat] |
| [`nufft/dtft.jl`][dtft-jl] | [`nufft/dtft.m`][dtft-mat] |
| [`regularize/Aodwt.jl`][odwt-jl] | [`penalty/Godwt1.m`][odwt-mat] |
| [`utility/mask.jl`][mask-jl] | [`utility/masker.m`][masker-mat] & [`utility/embed.m`][embed-mat] |


Matlab does not support named keyword arguments,
so the Matlab version of MIRT uses a custom approach called
[`vararg_pair`](https://github.com/JeffFessler/mirt/blob/master/utilities/vararg_pair.m)
[`vararg_pair`][vararg-mat]
as a work-around.
In Julia you replace any such use
with
In Julia, replace any such use with
[named keyword arguments](https://docs.julialang.org/en/v1/manual/functions/#Keyword-Arguments)
with appropriate default values.

When translating code from Matlab to Julia,
often you will need to locate some functions in Matlab version of MIRT.
To search for those functions,
one way is to go to the repo
https://github.com/JeffFessler/mirt
one way is to go to the
[mirt repo](https://github.com/JeffFessler/mirt)
and then enter the function name in the github search bar.
Github will then return a list like this
https://github.com/JeffFessler/mirt/search?q=vararg_pair
Github will then return a list
[like this][vararg-search].


<!-- URLs -->
[vararg-search]: https://github.com/JeffFessler/mirt/search?q=vararg_pair
[vararg-mat]: https://github.com/JeffFessler/mirt/blob/master/utilities/vararg_pair.m
[fld-read-jl]: https://github.com/JeffFessler/AVSfldIO.jl/blob/main/src/fld-read.jl
[fld-read-mat]: https://github.com/JeffFessler/mirt/blob/master/utilities/fld_read.m
[fld-write-jl]: https://github.com/JeffFessler/AVSfldIO.jl/blob/main/src/fld-write.jl
[fld-write-mat]: https://github.com/JeffFessler/mirt/blob/master/utilities/fld_write.m
[dtft-jl]: https://github.com/JeffFessler/MIRT.jl/blob/master/src/nufft/dtft.jl
[dtft-mat]: https://github.com/JeffFessler/mirt/blob/master/nufft/dtft.m
[kspace-jl]: https://github.com/JeffFessler/MIRT.jl/blob/master/src/mri/kspace.jl
[kspace-mat]: https://github.com/JeffFessler/mirt/blob/master/mri/ir_mri_kspace_ga_radial.m
[odwt-jl]: https://github.com/JeffFessler/MIRT.jl/blob/master/src/regularize/Aodwt.jl
[odwt-mat]: https://github.com/JeffFessler/mirt/blob/master/penalty/Godwt1.m
[sensemap-sim-jl]: https://github.com/JeffFessler/MIRT.jl/blob/master/src/mri/sensemap-sim.jl
[sensemap-sim-mat]: https://github.com/JeffFessler/mirt/blob/master/mri/mri_sensemap_sim.m
[mask-jl]: https://github.com/JeffFessler/MIRT.jl/blob/master/src/utility/mask.jl
[masker-mat]: https://github.com/JeffFessler/mirt/blob/master/utilities/masker.m
[embed-mat]: https://github.com/JeffFessler/mirt/blob/master/utilities/embed.m