Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream Episode 13 #64

Merged
merged 10 commits into from
Sep 29, 2018
Merged

Stream Episode 13 #64

merged 10 commits into from
Sep 29, 2018

Conversation

JoaquimLey
Copy link
Owner

No description provided.

Continue migrating the FavoritesViewModel implementation for the UseCase interactors

- Will create a Transport repository that takes the SMSController
- Handles the request and sends back the response.

#62
- Simplified the way how FlowableUseCases are executed
  - Removed a need of a specific Subscriber, and let consumer handle that

- Was wrongly building the useCases instead of executing in the FavVMImpl

- Renamed ui layer model to TransportUiModel (was FavoriteViewObject)

*UiModel will represent the viewState.

#62
- More tests related to favoritesViewmodel with use cases.

#62
This is the wrong branch to do this but oh well :).
- Changed a couple of things that made no sense from the domain side (the return type from Single to Observable

#63
@JoaquimLey JoaquimLey merged commit 035ce58 into develop Sep 29, 2018
@JoaquimLey JoaquimLey deleted the stream/episode_13 branch September 29, 2018 14:44
@JoaquimLey JoaquimLey self-assigned this Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant