Stream Episode 16: TransportDataStore implementation #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unit tests - Currently only using the (not yet implemented) FrameworkLocalStorage - Should be implemented by another module that uses SharedPreferences (Android Library) - A little hacky since SharedPrefs will always be Single events and the stream will be finished everytime Also left a lot of NotImplementedError to methods that shouldn't be used until we have a proper DB SharedPrefs will be limited to only 3 saved Entities. #69
JoaquimLey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests
Currently only using the (not yet implemented) FrameworkLocalStorage
Also left a lot of NotImplementedError to methods that shouldn't be used until we have a proper DB
SharedPrefs will be limited to only 3 saved Entities.
#69