-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extensions order #4053
fix: extensions order #4053
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the copy, that looks good now. The "Expenditures" group should be removed though and the extensions in that group should now be part of the "Payments" / "Decision Methods" groups as per the original issue:
- Decision methods
- Multi-sig
- Reputation Weighted (Lazy Consensus method)
- Staking Advanced Payments
- Payments
- One Transaction Payment
- Staged Payments
- Streaming Payments
@iamsamgibbs done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam-strzelec Looks and works great, thank you!
I do have one request, and that is to change the description for the streaming extension from the generic "Streaming Payments extension." to the following:
Continuously stream tokens to a recipient, that are claimable at any time. Useful for things like salaries, subscriptions, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this one @adam-strzelec 🙌
The extensions are alphabetically ordered both for the categories and within each category
And the copy for the Required Stake
in the Settings
tab is updated
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam-strzelec Thank you for updating the copy. All looks good!
bbc793d
into
feat/streaming-payments-ui
Description
Display extensions in alphabetical order and change copy for
Staking Advanced Payments
Testing
Order:
Extensions
pageStaking Advanced Payments copy:
Staking Advanced Payments
extensionExtension settings
tabOrder before install extension:

Order after install extension:

Staking Advanced Payments copy:

Resolves #2928