Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extensions order #4053

Merged

Conversation

adam-strzelec
Copy link
Contributor

@adam-strzelec adam-strzelec commented Jan 8, 2025

Description

Display extensions in alphabetical order and change copy for Staking Advanced Payments

Testing

Order:

  • Open Extensions page

Staking Advanced Payments copy:

  • Open Staking Advanced Payments extension
  • Go to Extension settings tab

Order before install extension:
Screenshot 2025-01-10 at 16 02 04

Order after install extension:
Screenshot 2025-01-10 at 16 02 35

Staking Advanced Payments copy:
Screenshot 2025-01-08 at 16 50 50

Resolves #2928

@adam-strzelec adam-strzelec requested a review from a team as a code owner January 8, 2025 15:59
@adam-strzelec adam-strzelec self-assigned this Jan 8, 2025
@AdrianDudko AdrianDudko linked an issue Jan 9, 2025 that may be closed by this pull request
Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the copy, that looks good now. The "Expenditures" group should be removed though and the extensions in that group should now be part of the "Payments" / "Decision Methods" groups as per the original issue:

- Decision methods
    - Multi-sig
    - Reputation Weighted (Lazy Consensus method)
    - Staking Advanced Payments
- Payments
    - One Transaction Payment
    - Staged Payments
    - Streaming Payments

Screenshot 2025-01-09 at 14 30 20

@adam-strzelec
Copy link
Contributor Author

@iamsamgibbs done 🙂

Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-strzelec Looks and works great, thank you!

I do have one request, and that is to change the description for the streaming extension from the generic "Streaming Payments extension." to the following:

Continuously stream tokens to a recipient, that are claimable at any time. Useful for things like salaries, subscriptions, and more.

image

Copy link
Contributor

@iamsamgibbs iamsamgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looks good to me now and the can confirm the copy has been updated.

Screenshot 2025-01-13 at 11 35 47

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this one @adam-strzelec 🙌

The extensions are alphabetically ordered both for the categories and within each category
Screenshot 2025-01-15 at 12 02 20

And the copy for the Required Stake in the Settings tab is updated
Screenshot 2025-01-15 at 12 02 48

Nice job!

Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-strzelec Thank you for updating the copy. All looks good!

@adam-strzelec adam-strzelec merged commit bbc793d into feat/streaming-payments-ui Jan 15, 2025
3 of 5 checks passed
@adam-strzelec adam-strzelec deleted the fix/16035732-extensions-order branch January 15, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension page fixes to order and grouping
4 participants