Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added builders for week indicator and for day header #28

Merged
merged 10 commits into from
Jul 12, 2020

Conversation

TatsuUkraine
Copy link
Contributor

Closes: #27

Added 2 builders for header:
weekIndicatorBuilder and dayHeaderBuilder

Both builder signed with same typedef, which is

typedef HeaderBuilder = Widget Function(
  BuildContext context,
  LocalDate date
);

Both builders are optional. If builder is not provided or it returns null - default (current one) header widgets will be used.

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Copy link
Owner

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! I like the feature and its implementation; the comments are just about naming and code formatting

@JonasWanke JonasWanke added C: Timetable Component: The actual timetable package T: Feature Type: :tada: New Features labels Jul 11, 2020
@TatsuUkraine
Copy link
Contributor Author

Will do, thanks. I just can't get why code check fails(

@JonasWanke
Copy link
Owner

Both failing checks try to create a comment on this PR for which they need an access token. The two required tokens are stored as secrets in this repo but can't be accessed when the GitHub actions are executed on a fork. You ignore their failure (flutter analyze doesn't report errors locally).

(I'll have to find a workaround for this problem as soon as I have a bit more spare time.)

@TatsuUkraine
Copy link
Contributor Author

all items are fixed, except this one

@JonasWanke JonasWanke merged commit b4dd81f into JonasWanke:master Jul 12, 2020
@JonasWanke
Copy link
Owner

This is now published as part of v0.2.6. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Timetable Component: The actual timetable package T: Feature Type: :tada: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to build custom header
2 participants