-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added builders for week indicator and for day header #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR! I like the feature and its implementation; the comments are just about naming and code formatting
Will do, thanks. I just can't get why code check fails( |
Both failing checks try to create a comment on this PR for which they need an access token. The two required tokens are stored as secrets in this repo but can't be accessed when the GitHub actions are executed on a fork. You ignore their failure ( (I'll have to find a workaround for this problem as soon as I have a bit more spare time.) |
Co-authored-by: Jonas Wanke <[email protected]>
Co-authored-by: Jonas Wanke <[email protected]>
Co-authored-by: Jonas Wanke <[email protected]>
Co-authored-by: Jonas Wanke <[email protected]>
all items are fixed, except this one |
This is now published as part of v0.2.6. Thanks for contributing! |
Closes: #27
Added 2 builders for header:
weekIndicatorBuilder
anddayHeaderBuilder
Both builder signed with same typedef, which is
Both builders are optional. If builder is not provided or it returns
null
- default (current one) header widgets will be used.Checklist