Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix week scroll alignment #6

Merged
merged 1 commit into from
May 8, 2020
Merged

fix week scroll alignment #6

merged 1 commit into from
May 8, 2020

Conversation

JonasWanke
Copy link
Owner

@JonasWanke JonasWanke commented May 8, 2020

Both manual scrolling between days and programmatically focusing a specific date now work as intended and are tested.

Breaking change

To provide a simpler API the exposed methods of VisibleRange were changed slightly. This doesn't affect you if you just instantiate one of the given implementations, but only if you extend it yourself or call one of its methods directly.

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@JonasWanke JonasWanke added T: Fix Type: :bug: Bug Fixes PR: BREAKING labels May 8, 2020
@JonasWanke JonasWanke self-assigned this May 8, 2020
@unicorn-bot
Copy link

❌ Unicorn Report

❌ 1 Error

ℹ️ 1 Info

  • This PR won't close any issues
    Reference issues in you PR description using Closes: #issueId

Generated by 🦄 Unicorn
Report an issue

@unicorn-bot unicorn-bot added the C: Timetable Component: The actual timetable package label May 8, 2020
@jwbot
Copy link
Collaborator

jwbot commented May 8, 2020

Flutter Analyze found 0 issues ✅

Generated by 🚫 Danger

@JonasWanke JonasWanke merged commit dcf63d4 into master May 8, 2020
@JonasWanke JonasWanke deleted the fix/week-scrolling branch May 8, 2020 08:20
@JonasWanke JonasWanke changed the title Fix week scroll alignment fix week scroll alignment May 8, 2020
@ghost ghost mentioned this pull request Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Timetable Component: The actual timetable package PR: BREAKING T: Fix Type: :bug: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants