Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all great PR!
Since a major part of the work in rari is moving strings around I tried to allocate as little as necessary. When I changed most strings to Cows it really made a difference in sum.
That's why there's
Cow
s everywhere. I'm thinking about making this more ergonomic in the future and I will definitely add this in a contributing guide.That's the difference in this PR doing a simple
get_group("EvalError", &[])
:Feel free to ping me if you want to chat about this.